[PATCH] D94996: [GVN] do not repeat PRE on failure to split critical edge

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers marked 2 inline comments as done.
nickdesaulniers added inline comments.


================
Comment at: llvm/test/Transforms/GVN/critical-edge-split-failure.ll:2
+; RUN: opt -gvn -S -o - %s | FileCheck %s
+; RUN: opt -passes=gvn -S -o - %s | FileCheck %s
+
----------------
aeubanks wrote:
> fhahn wrote:
> > aeubanks wrote:
> > > nickdesaulniers wrote:
> > > > This is yet another case where NPM test passes before/after a patch that would be red with LPM. cc @aeubanks 
> > > > 
> > > > I don't know if this test should be under
> > > > 
> > > > llvm/test/Transforms/GVN/PRE/
> > > > rather than
> > > > llvm/test/Transforms/GVN/
> > > > ?
> > > This one is much more surprising, I can't think of anything off the top of my head that would cause the output of running GVN to change between the two pass managers.
> > missing `aa-pipeline` option?
> Haha I just sent out https://reviews.llvm.org/D95117 to use the "default" AA pipeline by default and still forgot about it here. Seems like the likely culprit.
Adding `-aa-pipeline=default` (or `-aa-pipeline=`) doesn't seem to cause the NPM RUN line to fail (before adding this patch). Am I holding it wrong, or is there still more to this difference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94996/new/

https://reviews.llvm.org/D94996