[PATCH] D94938: [lld-macho][NFC] Add new option group for versions

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 09:02:59 PST 2021


compnerd added a comment.

Sure, but if the reason for the group is to add structure to the help output, I think that is a reasonable thing to state in the commit message.  The other options are ... well, either not meant to be part of the commit as per the commit message or the commit message should be updated to indicate that they are being added (and why they are part of structuring the help output, assuming that is the reason for the group).  The changes requested are requests for clarification :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94938/new/

https://reviews.llvm.org/D94938



More information about the llvm-commits mailing list