[PATCH] D94652: [RISCV] Move Shift Ones instructions from Zbb to Zbp to match 0.93 bitmanip spec.

Thu Jan 21 07:58:05 PST 2021

asb added a comment.

In D94652#2512063 <https://reviews.llvm.org/D94652#2512063>, @frasercrmck wrote:

> In D94652#2509956 <https://reviews.llvm.org/D94652#2509956>, @craig.topper wrote:
>
>> My hope is to get the 0.93 move into LLVM 12. Zbb is marked frozen in the 0.93 spec and does not include these. So I'd at least like them out of Zbb. Would it be better to just remove them until they have a home?
>
> Mm yes, if Zbb is frozen and doesn't include them then I agree they need to go somewhere. Removing them sounds a bit drastic. If the release branch will be created in 6 days, how long can we delay the decision?

We could backport the patch after the branch. The release manager has been very accommodating in the past, but we should do what we can to avoid generating unnecessary work. It's a shame there's no answer on the issue yet https://github.com/riscv/riscv-bitmanip/issues/105

I think making the assumption that they probably meant to move to Zbp should be fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94652/new/

https://reviews.llvm.org/D94652