[PATCH] D94805: [flang][driver] Update PP tests to use the new driver

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 07:27:27 PST 2021


awarzynski accepted this revision.
awarzynski added a comment.

This change:

- preserves the current behavior when `FLANG_BUILD_NEW_DRIVER=OFF`
- adds a lot of new tests for `flang-new` when `FLANG_BUILD_NEW_DRIVER=ON` at almost no cost

Really nice to see this patch! I have two suggestions for the future:

- when `flang-new` becomes `flang`, we should update `flang-driver` accordingly
- also, we could switch to `flang-new -fc1` instead of `flang-new`

I don't see a good reason for these to happen just now - one step at a time! LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94805/new/

https://reviews.llvm.org/D94805



More information about the llvm-commits mailing list