[PATCH] D95126: [llvm-link] Fix for an assertion when linking global with appending linkage

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Given the langref text I'm unsure what it means to link an append linkage variable to a non-append linkage one. I can see how extern is different but what would happen before & now if you remove the extern. And what happens before/now if you have append on both `@var`? We should add those tests if possible.



================
Comment at: llvm/lib/Linker/IRMover.cpp:933
+      *NG, DstGV && !DstGV->isDeclaration() ? DstGV->getInitializer() : nullptr,
+      IsOldStructor, SrcElements);
 
----------------
parenthesis around the condition please. maybe move it to a new line given the complexity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95126/new/

https://reviews.llvm.org/D95126