[PATCH] D95088: [InstCombine] avoid crashing on attribute propagation

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1157
+  NewCI->removeAttributes(AttributeList::ReturnIndex,
+                          AttributeFuncs::typeIncompatible(NewCI->getType()));
   return B.CreateInBoundsGEP(B.getInt8Ty(), Dst, N);
----------------
spatel wrote:
> jdoerfert wrote:
> > We could attach (some, if not all) return value attributes to the first operand in order to preserve them. I guess a FIXME would do for now if you don't feel like including this.
> I haven't looked at what is currently possible with attribute transforms other than this, so I'll add a comment. Not sure if/when I can extend the patch.
Comment is fine. This bug needs fixing ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95088/new/

https://reviews.llvm.org/D95088