[PATCH] D94457: [AArch64] Add some missing fusion subtarget features

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Thank, LGTM.

In D94457#2491639 <https://reviews.llvm.org/D94457#2491639>, @porglezomp wrote:

> The existing fusion tests seem a little bit weak—the machine scheduler with the base Cortex-A57 machine models that most of those use seemed to pass the address and literal fusion on its own (by coincidence?) without the explicit features requested. I was unable to make that test case stronger to see the A57 machine model not exploiting those fusion pairs when the feature was disabled. Is that worth worrying about?

Yeah, perhaps there's room for improvement, it's not something that worries me very much.



================
Comment at: llvm/lib/Target/AArch64/AArch64.td:221
 
+def FeatureCmpBccFusion : SubtargetFeature<
+    "cmp-bcc-fusion", "HasCmpBccFusion", "true",
----------------
Yep, makes sense I think.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:623
+                                   FeatureFuseAES,
+                                   FeatureFuseLiterals,
                                    FeatureNEON,
----------------
Check


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:636
                                    FeatureFuseAES,
+                                   FeatureFuseLiterals,
                                    FeatureNEON,
----------------
Check


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:668
                                     FeatureFPARMv8,
+                                    FeatureFuseAES,
                                     FeatureNEON,
----------------
Check


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:682
                                     FeatureFPARMv8,
+                                    FeatureFuseAES,
                                     FeatureNEON, FeatureRCPC,
----------------
Check


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:693
                                HasV8_2aOps,
+                               FeatureCmpBccFusion,
                                FeatureCrypto,
----------------
Check


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:710
                                 HasV8_2aOps,
+                                FeatureCmpBccFusion,
                                 FeatureCrypto,
----------------
Check


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:738
                                   HasV8_2aOps,
+                                  FeatureCmpBccFusion,
                                   FeatureCrypto,
----------------
Check


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94457/new/

https://reviews.llvm.org/D94457