[PATCH] D88390: [M68k] (Patch 4/8) MC layer and object file support

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 02:51:36 PST 2021


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp:4
-// LLVM<Target>CodeGen need to be present and some APIs
-// like `LLVMInitializeM68kTarget` need to be there
 
----------------
RKSimon wrote:
> myhsu wrote:
> > RKSimon wrote:
> > > We should probably have the boilerplate comments in the initial version of the file?
> > sorry I don't quite get what you said: what is the boilerplate comments here? is it the license + "This file provides M68k target specific descriptions." on the right?
> Yes - the comment block containing the license etc.
Please can you update D88389 with these changes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390



More information about the llvm-commits mailing list