[PATCH] D94007: [CSKY 5/n] Add support for all CSKY basic integer instructions except for branch series

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

Can you also link patch 1~3 as the related revisions as well?



================
Comment at: llvm/lib/Target/CSKY/AsmParser/CSKYAsmParser.cpp:498
 
+  // Attempt to parse token as (registe, imm)
+  if (getLexer().is(AsmToken::LParen))
----------------
(typo) registe -> register


================
Comment at: llvm/lib/Target/CSKY/CSKYInstrFormats.td:407
   let Inst{15 - 10} = sop;
-  let Inst{9 - 5} = pcode; // pcode;
+  let Inst{9 - 5} = imm;  // pcode;
   let Inst{4 - 0} = rz;
----------------
Is the imm here still pcode?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94007/new/

https://reviews.llvm.org/D94007