[PATCH] D95084: [lld][benchmark] Be tolerant of optional metric units in output

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/test/CMakeLists.txt:38
   list(APPEND LLD_TEST_DEPS LLDUnitTests)
+  list(APPEND LLD_TEST_DEPS check-lld-benchmark)
 endif()
----------------
compnerd wrote:
> This doesn't seem correct - the `check-*` shouldn't be a dependency for running tests.
True, but neither is `LLDUnitTests`, and I was following its lead...

Looking at `llvm/CMakeLists.txt`, it seems that over there they define a LLVM_ADDITIONAL_TEST_TARGETS variable that gets added as a dependency to the `check-all` target, alongside the test dependencies for the main test suite; I guess we could do something similar here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95084/new/

https://reviews.llvm.org/D95084