[PATCH] D95088: [InstCombine] avoid crashing on attribute propagation
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 20 14:00:05 PST 2021
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM, one comment below though.
================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1157
+ NewCI->removeAttributes(AttributeList::ReturnIndex,
+ AttributeFuncs::typeIncompatible(NewCI->getType()));
return B.CreateInBoundsGEP(B.getInt8Ty(), Dst, N);
----------------
We could attach (some, if not all) return value attributes to the first operand in order to preserve them. I guess a FIXME would do for now if you don't feel like including this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95088/new/
https://reviews.llvm.org/D95088
More information about the llvm-commits
mailing list