[PATCH] D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/recursion-compression.test:1
+; Firstly test uncompression(--compress-recursion=0)
+; RUN: llvm-profgen --perfscript=%S/Inputs/recursion-compression.perfscript --binary=%S/Inputs/recursion-compression.perfbin --output=%t --compress-recursion=0
----------------
A test case to cover line-based profile too? That goes through slightly different path for handling the inline context expansion, so e2e test would be good (doesn't have to be as through as the one for probe though).


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.h:96
+  template <typename T>
+  static void compressRecursionContext(SmallVectorImpl<T> &Context) {
+    compressRecursionContext<T>(Context, MaxCompressionSize == -1
----------------
We could remove this redirector, and just use default parameter? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93556/new/

https://reviews.llvm.org/D93556