[PATCH] D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:836
       case CodeGenIntrinsic::ReadArgMem:
+        if (intrinsic.hasSideEffects)
+          break;
----------------
Thinking about this again, I think the entire switch should be skipped if hasSideEffects is set. None of the cases are valid.

Which is implied by the if statement earlier checking

```
(intrinsic.ModRef != CodeGenIntrinsic::ReadWriteMem && !intrinsic.hasSideEffects)
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76127/new/

https://reviews.llvm.org/D76127