[PATCH] D94378: [LoopDeletion] Handle inner loops w/untaken backedges
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 20 10:43:00 PST 2021
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:805
+ // loop which might have a had a block removed.
+ if (OutermostLoop != L)
+ formLCSSARecursively(*OutermostLoop, DT, &LI, &SE);
----------------
>From the arguments, it seems like `changeToUnreachable` at least tries to preserve LCSSA, but clearly misses the case at hand. I've not looked at the details on what exactly needs updating Do you think it would be possible to directly fix the values broken after removing the block?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94378/new/
https://reviews.llvm.org/D94378
More information about the llvm-commits
mailing list