[PATCH] D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it

Wed Jan 20 10:05:08 PST 2021

paquette added a comment.

Can you add selection tests for `s32` and `s64`?

I think you can probably

- Copy test/CodeGen/AArch64/GlobalISel/select-uaddo.mir -> test/CodeGen/AArch64/GlobalISel/select-usubo.mir
- Replace G_UADDO with G_USUBO
- Generate the check lines using utils/update_mir_test_checks.py

and that should cover it.

================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalize-add.mir:78
+---
+name:            test_scalar_uaddo_32
+body:             |
----------------
I think I'd note in the commit message that you also improved testing for the other overflow ops. (Or, do this separately in a NFC commit.) Otherwise, someone 3 years down the line doing git history archaeology may be confused. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95032/new/

https://reviews.llvm.org/D95032