[PATCH] D94907: [llvm-nm][ELF] - Make -D display symbol versions.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

LGTM.



================
Comment at: llvm/test/tools/llvm-nm/dynamic.test:146
+
+# VERSION-ERR-NEXT: U globalversym
+# VERSION-ERR-NEXT: U localversym
----------------
Perhaps append `{{$}}` or use FileCheck `--match-full-lines`


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1789
+    size_t I = -1;
     for (BasicSymbolRef Sym : Symbols) {
+      ++I;
----------------
Perhaps llvm::enumerate


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94907/new/

https://reviews.llvm.org/D94907