[PATCH] D94782: [flang][driver] Make the driver report diagnostics from the prescanner

Wed Jan 20 09:31:24 PST 2021

sameeranjoshi added inline comments.

================
Comment at: flang/test/Frontend/preprocessor-diag.f90:9
+#include <empty.h> comment
+! ERROR: :10:20: #include: extra stuff ignored after file name
+#include "empty.h" comment
----------------
awarzynski wrote:
> sameeranjoshi wrote:
> > I discovered just now that the output isn't a error but seems like a warning.
> > I feel using `--check-prefix=WARNING` would be correct.
> Good point, thank you! I'm hesitant to use `WARNING`, as there is nothing that it would indicate that it's actually a warning. FWIW, it's just a diagnostic message without any severity attached to it.
> 
> Are you OK with regular `CHECK` ?
Go ahead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94782/new/

https://reviews.llvm.org/D94782