[PATCH] D95056: [CSSPGO] LTO option for pseudo probe

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Config.h:178
   bool ltoNewPassManager;
+  bool ltoPseudoProbeForProfiling = false;
   bool ltoUniqueBasicBlockSectionNames;
----------------
Omit initializer


================
Comment at: lld/test/ELF/lto/pseudo-probe-lto.ll:1
+; REQUIRES: x86_64-linux
+; RUN: opt < %s -passes=pseudo-probe -function-sections -o %t.o
----------------
This is not satisfied.

`; REQUIRES: x86`


================
Comment at: lld/test/ELF/lto/pseudo-probe-lto.ll:21
+
+; CHECK: .section .pseudo_probe_desc,"G", at progbits,.pseudo_probe_desc_foo,comdat
+; CHECK-NEXT: .quad [[#GUID]]
----------------
```
; CHECK:      .section
; CHECK-NEXT:   .quad [[#GUID]]
```


================
Comment at: lld/test/ELF/lto/pseudo-probe-lto.ll:32
+!1 = !DIFile(filename: "test.c", directory: "")
+!2 = !{}
+!4 = distinct !DISubprogram(name: "foo", scope: !1, file: !1, line: 2, type: !5, unit: !0, retainedNodes: !2)
----------------
can some metadata be simplified?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95056/new/

https://reviews.llvm.org/D95056