[PATCH] D92309: [LegacyPM] Update InversedLastUser on the fly. NFC.

Wed Jan 20 08:27:08 PST 2021

foad added a comment.

In D92309#2509618 <https://reviews.llvm.org/D92309#2509618>, @bjope wrote:

> In D92309#2509524 <https://reviews.llvm.org/D92309#2509524>, @foad wrote:
>
>> In D92309#2509390 <https://reviews.llvm.org/D92309#2509390>, @bjope wrote:
>>
>>> LGTM
>>
>> Thanks. This patch depends on D92308 <https://reviews.llvm.org/D92308>. Without D92308 <https://reviews.llvm.org/D92308>, this patch would add lots of extra lines to the output of `opt -debug-pass=Structure`, which breaks various tests in test/CodeGen and test/Other.
>
> Maybe an alternative to D92308 <https://reviews.llvm.org/D92308> would be to bail out from dumpLastUses if (PassDebugging < Details). I.e. to limit the dumping of last uses to -debug-pass=Details.
> I do not think it is that harmful to get more printouts when using Details level for debug-pass. And this way one can get the detailed information when debugging the pass manager on detailed level, while not impacting tests using -debug-pass=Structure etc.
>
> (if that sounds good, then I guess you can even squeeze that into this revision)

Good idea!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92309/new/

https://reviews.llvm.org/D92309