[PATCH] D95051: [AMDGPU] pin lit test divergent-unswitch.ll to the old pass manager

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 20 08:09:13 PST 2021


sameerds created this revision.
Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
sameerds requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

The loop-unswitch transform should not be performed on a loop whose
condition is divergent. For this to happen correctly, divergence
analysis must be available. The existing divergence analysis has not
been ported to the new pass manager yet. As a result, loop unswitching
on the new pass manager is currently unsafe on targets that care about
divergence.

This test is temporarily disabled to unblock work on the new pass
manager. The issue is now tracked in bug 48819.

Change-Id: I05da823b1377c9a1d61ce8bc8ea11eb0bb09f0f1


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95051

Files:
  llvm/test/Transforms/LoopUnswitch/AMDGPU/divergent-unswitch.ll


Index: llvm/test/Transforms/LoopUnswitch/AMDGPU/divergent-unswitch.ll
===================================================================
--- llvm/test/Transforms/LoopUnswitch/AMDGPU/divergent-unswitch.ll
+++ llvm/test/Transforms/LoopUnswitch/AMDGPU/divergent-unswitch.ll
@@ -1,4 +1,7 @@
-; RUN: opt -mtriple=amdgcn-- -O3 -S %s | FileCheck %s
+; RUN: opt -mtriple=amdgcn-- -O3 -S -enable-new-pm=0 %s | FileCheck %s
+
+; This fails with the new pass manager:
+; https://bugs.llvm.org/show_bug.cgi?id=48819
 
 ; Check that loop unswitch happened and condition hoisted out of the loop.
 ; Condition is uniform so all targets should perform unswitching.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95051.317885.patch
Type: text/x-patch
Size: 650 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210120/aa7333de/attachment-0001.bin>


More information about the llvm-commits mailing list