[PATCH] D95036: [NFC][AMDGPU] Split AMDGPUSubtarget.h to R600 and GCN subtargets.

[Daniil Fukalov via Phabricator via llvm-commits]

dfukalov marked an inline comment as done.
dfukalov added a comment.

The main reason was reducing include dependencies and so source files re-builds. At the moment both GCN and R600 targets rebuild if one just changes one option in GCN related code. Actually this is the first part of split, I was thinking about splitting AMDGPUSubtarget.cpp then, and following AMDGPUMCTargetDesc.h (it currently contains both GCN+R600 tablegen output).



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:242-261
+const FeatureBitset GCNTTIImpl::InlineFeatureIgnoreList = {
+    // Codegen control options which don't matter.
+    AMDGPU::FeatureEnableLoadStoreOpt, AMDGPU::FeatureEnableSIScheduler,
+    AMDGPU::FeatureEnableUnsafeDSOffsetFolding, AMDGPU::FeatureFlatForGlobal,
+    AMDGPU::FeaturePromoteAlloca, AMDGPU::FeatureUnalignedScratchAccess,
+    AMDGPU::FeatureUnalignedAccessMode,
+
----------------
arsenm wrote:
> This looks like an unrelated change
I moved this initialization out from header since otherwise it should include quire heavy AMDGPUMCTargetDesc.h with definitions of AMDGPU::<option>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95036/new/

https://reviews.llvm.org/D95036