[PATCH] D94712: Do not traverse ConstantData use-list in LookInterchange

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

> Do not traverse ConstantData use-list in LookInterchange

There's a typo in the title: `LookInterchange` -> `LoopInterchange`. Please adjust before committing.



================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:666
+    // The function is looking for reduction variables, which cannot be
+    // constants; also walking users of some Constants (particularly
+    // ConstantData) doesn't make semantic sense in a function pass since
----------------
thanks for the comment. The bit about walking users of constants seems a bit verbose and I think it would be better to have this rule documented in a single place, rather than adding it at all the places that are going to be updated. I'd remove it here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94712/new/

https://reviews.llvm.org/D94712