[PATCH] D93478: [LoopVectorizer] Fix invalid scenario that is allowed to interleave

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 20 07:04:04 PST 2021


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:1268
+  // Check if reduction has invalid type for interleaving.
+  for (auto &Reduction : *getReductionVars()) {
+    auto Descriptor = Reduction.second;
----------------
Could you elaborate why the type width would matter here? Is it possible that this only exposed a problem somewhere else, e.g. lowering operations on vectors of `i1`?

(I tried to reproduce the problem with current trunk on macOS, but failed)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93478/new/

https://reviews.llvm.org/D93478



More information about the llvm-commits mailing list