[PATCH] D94795: [AMDGPU] Fix use of HasModifiers in VopProfile
Mirko Brkusanin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 20 02:28:41 PST 2021
mbrkusanin added a comment.
In D94795#2501775 <https://reviews.llvm.org/D94795#2501775>, @arsenm wrote:
> Do we really need HasModifiers if breaking this down to src modifiers and omod?
This
"field bit HasSrc0Mods = HasModifiers;"
basically tells us that we can replace all uses of HasModifiers with HasSrc0Mods. I guess it's more of a question of readability.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94795/new/
https://reviews.llvm.org/D94795
More information about the llvm-commits
mailing list