[PATCH] D88390: [M68k] (Patch 4/8) MC layer and object file support

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kInstPrinter.cpp:181
+
+void M68kInstPrinter::printPCDMem(const MCInst *MI, uint64_t Address,
+                                    int opNum, raw_ostream &O) {
----------------
jrtc27 wrote:
> myhsu wrote:
> > MaskRay wrote:
> > > The PCREL_OPERAND style `print*` functions are usually used this way: D77853
> > Well...actually Motorola is using its own assembly language (and where this `(N,%pc)` syntax comes from). We're trying to conform with that in order to have better coordination with other existing toolchains
> The objdump output is not the same as the asm input/codegen output in this specific case. What does binutils's objdump do for m68k?
I think I can answer this question now: GCC, GNU AS and this M68k backend all use Motorola's own assembly syntax.
objdump, on the hand, doesn't. I'm not clean what they use but it looks like reusing the existing ATT syntax or so.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCAsmInfo.cpp:22
+
+// TODO get back to it when it comes to printing
+M68kELFMCAsmInfo::M68kELFMCAsmInfo(const Triple &T) {
----------------
jrtc27 wrote:
> What does this mean?
seems to be a stale comments, removing it now


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp:4
-// LLVM<Target>CodeGen need to be present and some APIs
-// like `LLVMInitializeM68kTarget` need to be there
 
----------------
RKSimon wrote:
> We should probably have the boilerplate comments in the initial version of the file?
sorry I don't quite get what you said: what is the boilerplate comments here? is it the license + "This file provides M68k target specific descriptions." on the right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390