[PATCH] D94895: [X86] Add experimental option to separately tune alignment of innermost loops

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:51631
+    return Align(1ULL << ExperimentalPrefInnermostLoopAlignment);
+  return TargetLowering::getPrefLoopAlignment();
+}
----------------
Should it be `Align(1ULL << ExperimentalPrefLoopAlignment)`?


================
Comment at: llvm/test/CodeGen/X86/innermost-loop-alignment.ll:3
+; RUN: llc < %s -mtriple=i686-pc-linux-gnu | FileCheck %s -check-prefix=DEFAULT
+; RUN: llc < %s -mtriple=i686-pc-linux-gnu -x86-experimental-pref-innermost-loop-alignment=5 | FileCheck %s -check-prefix=ALIGN32
+
----------------
Should add a test for combination with option `x86-experimental-pref-loop-alignment`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94895/new/

https://reviews.llvm.org/D94895