[PATCH] D95009: [llvm-profgen][NFC] Fix the incorrect computation of callsite sample count

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 17:01:30 PST 2021


wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:278
+                                  uint64_t Count) {
+  if (LeafLoc.second.LineOffset & 0x80000000)
+    return;
----------------
hoy wrote:
> What is this check?
Good catch! This is to filter the invalid negative LineOffset same as `updateBodySamplesforFunctionProfile`. but I think here it's only for the inferred context, shouldn't have the negative line. I will remove this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95009/new/

https://reviews.llvm.org/D95009



More information about the llvm-commits mailing list