[PATCH] D93556: [CSSPGO][llvm-profgen] Compress recursive cycles in calling context

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 16:45:23 PST 2021


wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.h:20
+// External storage of command line
+extern int32_t CompressionSize;
+
----------------
hoy wrote:
> Remove this?
Good catch!


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.h:230
+  // length.
+  static int32_t MaxCompressionSize;
 };
----------------
hoy wrote:
> Nit: add a comment about the special value -1?
Good point!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93556/new/

https://reviews.llvm.org/D93556



More information about the llvm-commits mailing list