[PATCH] D94954: Fixes Snapdragon Kryo CPU core detection

Ryan Houdek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 14:11:44 PST 2021


Sonicadvance1 updated this revision to Diff 317689.
Sonicadvance1 edited the summary of this revision.
Sonicadvance1 added a comment.
Herald added a subscriber: kristof.beyls.

There was a desync between Implementer and Part scans.
Implementer would scan to the end of /proc/cpuinfo, setting the implementer to 0x41 (ARM) but then the StringSwitch loop would return the first definition it would find. Which was CPU part 0x805, which doesn't exist for implementer 0x41 because that was actually a 0x51 implementer part.
Moves the Part scan to the start alongside the Implementer scan so these two values stay in sync across platforms that mix implementers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94954/new/

https://reviews.llvm.org/D94954

Files:
  llvm/lib/Support/Host.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94954.317689.patch
Type: text/x-patch
Size: 8463 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210119/afd726b4/attachment.bin>


More information about the llvm-commits mailing list