[PATCH] D94851: [InstCombine] Don't transform (select c, ext(TI), ext(FI)) if ext is free

Tue Jan 19 14:02:18 PST 2021

Carrot added a comment.

In D94851#2507869 <https://reviews.llvm.org/D94851#2507869>, @lebedev.ri wrote:

> In D94851#2507867 <https://reviews.llvm.org/D94851#2507867>, @Carrot wrote:
>
>> Thanks for the info.
>>
>> I will discard this patch and reverse the pattern at function CodeGenPrepare::optimizeExt.
>
> Not really sure why that would go into `CodeGenPrepare`, which is a temporary hack,
> DAGCombine is the usual counterpart.

Because I found CodeGenPrepare::optimizeExt does some ext(load( )) optimization.
Will look into DAGCombine.
Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94851/new/

https://reviews.llvm.org/D94851