[PATCH] D94982: [NPM][Inliner] Factor ImportedFunctionStats in the InlineAdvisor

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

Do you have an example showing the non-determinsticness ?



================
Comment at: llvm/include/llvm/Analysis/InlineAdvisor.h:15
 #include "llvm/IR/PassManager.h"
+#include "llvm/Transforms/Utils/ImportedFunctionsInliningStatistics.h"
 #include <memory>
----------------
Should the file be moved to the Analysis directory?


================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:447
+    : M(M), FAM(FAM) {
+  if (!ImportedFunctionsStats &&
+      InlinerFunctionImportStats != InlinerFunctionImportStatsOpts::No) {
----------------
Why is the first check needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94982/new/

https://reviews.llvm.org/D94982