[PATCH] D94993: [lld][WebAssembly] Don't defined indirect function table in relocatable output

Tue Jan 19 12:57:53 PST 2021

sbc100 added inline comments.

================
Comment at: lld/test/wasm/locals-duplicate.test:241
+; RELOC-NEXT:          Index:           0
+; RELOC-NEXT:          ElemType:        FUNCREF
+; RELOC-NEXT:          Limits:
----------------
dschuff wrote:
> dschuff wrote:
> > is this elemtype correct? do we just not distinguish right now?
> Looks like the answer is that we only have FUNCREF and EXTERNREF right now. Maybe doesn't matter for this case, I guess that's something we can fix in the future.
This is correct I think yes.  This is the only possible elem type today I think.   What else would you expect it to say here?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94993/new/

https://reviews.llvm.org/D94993