[PATCH] D94853: [NFC] Disallow unused prefixes under Other

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin updated this revision to Diff 317649.
mtrofin added a comment.

added FIXME for the %FileChechRaw% substitution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94853/new/

https://reviews.llvm.org/D94853

Files:
  llvm/test/Other/lit.local.cfg
  llvm/test/Other/new-pass-manager.ll
  llvm/test/Other/opt-LTO-pipeline.ll
  llvm/test/Other/opt-bisect-legacy-pass-manager.ll
  llvm/test/Other/print-slotindexes.ll


Index: llvm/test/Other/print-slotindexes.ll
===================================================================
--- llvm/test/Other/print-slotindexes.ll
+++ llvm/test/Other/print-slotindexes.ll
@@ -1,5 +1,5 @@
-; RUN: llc -print-after=slotindexes < %s 2>&1 | FileCheck %s --check-prefixes=ALL,SI 
-; RUN: llc -print-after=slotindexes -print-slotindexes=false < %s 2>&1 | FileCheck %s --check-prefixes=ALL,NOSI
+; RUN: llc -print-after=slotindexes < %s 2>&1 | FileCheck %s --check-prefixes=CHECK,SI 
+; RUN: llc -print-after=slotindexes -print-slotindexes=false < %s 2>&1 | FileCheck %s --check-prefixes=CHECK,NOSI
 ; REQUIRES: default_triple
 define void @foo(){
   ret void
Index: llvm/test/Other/opt-bisect-legacy-pass-manager.ll
===================================================================
--- llvm/test/Other/opt-bisect-legacy-pass-manager.ll
+++ llvm/test/Other/opt-bisect-legacy-pass-manager.ll
@@ -39,7 +39,7 @@
 ; f2() in f3().
 
 ; RUN: %python %S/opt-bisect-helper.py --start=0 --end=256 --optcmd=opt \
-; RUN:         --filecheckcmd=FileCheck --test=%s \
+; RUN:         --filecheckcmd=%FileCheckRaw% --test=%s \
 ; RUN:         --prefix=CHECK-BISECT-INLINE-HELPER \
 ; RUN:         | FileCheck %s --check-prefix=CHECK-BISECT-INLINE-RESULT
 ; The helper script uses this to find the optimization that inlines the call.
Index: llvm/test/Other/opt-LTO-pipeline.ll
===================================================================
--- llvm/test/Other/opt-LTO-pipeline.ll
+++ llvm/test/Other/opt-LTO-pipeline.ll
@@ -1,4 +1,4 @@
-; RUN: opt -enable-new-pm=0 -mtriple=x86_64-- -std-link-opts -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck --check-prefixes=CHECK,%llvmcheckext %s
+; RUN: opt -enable-new-pm=0 -mtriple=x86_64-- -std-link-opts -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK %s
 
 ; REQUIRES: asserts
 
Index: llvm/test/Other/new-pass-manager.ll
===================================================================
--- llvm/test/Other/new-pass-manager.ll
+++ llvm/test/Other/new-pass-manager.ll
@@ -366,6 +366,9 @@
 ; CHECK-EXT-NEXT: Starting llvm::Function pass manager run.
 ; CHECK-EXT-NEXT: Running pass: {{.*}}Bye
 ; CHECK-EXT-NEXT: Finished llvm::Function pass manager run.
+; We don't have checks for CHECK-NOEXT here, but this simplifies the test, while
+; avoiding FileCheck complaining about the unused prefix.
+; CHECK-NOEXT: {{.*}}
 ; CHECK-O0-NEXT: Finished llvm::Module pass manager run
 
 ; RUN: opt -disable-output -disable-verify -debug-pass-manager \
Index: llvm/test/Other/lit.local.cfg
===================================================================
--- /dev/null
+++ llvm/test/Other/lit.local.cfg
@@ -0,0 +1,12 @@
+from lit.llvm.subst import ToolSubst
+
+fc = ToolSubst('FileCheck', unresolved='fatal')
+# Insert this first. Then, we'll first update the blank FileCheck command; then,
+# the default substitution of FileCheck will replace it to its full path.
+config.substitutions.insert(0, (fc.regex,
+    'FileCheck --allow-unused-prefixes=false'))
+
+# FIXME: this substitution should be removed together with the above, when the
+# default --allow-unused-prefixes is fixed. At that point, the use of %FileCheckRaw%
+# in opt-bisect-legacy-pass-manager.ll should be switched back to just FileCheck.
+config.substitutions.append(('%FileCheckRaw%', 'FileCheck'))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94853.317649.patch
Type: text/x-patch
Size: 3357 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210119/7e783615/attachment.bin>