[PATCH] D94853: [NFC] Disallow unused prefixes under Other

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/test/Other/lit.local.cfg:6-7
+# the default substitution of FileCheck will replace it to its full path.
+config.substitutions.insert(0, (fc.regex,
+    'FileCheck --allow-unused-prefixes=false'))
+config.substitutions.append(('%FileCheckRaw%', 'FileCheck'))
----------------
aeubanks wrote:
> mtrofin wrote:
> > aeubanks wrote:
> > > pardon my ignorance, but why is this substitution necessary? does opt-bisect-legacy-pass-manager.ll break with `--allow-unused-prefixes=true`?
> > It's not that it breaks because of duplicate flags, it breaks because opt-bisect-helper.py has trouble starting a process called "FileCheck --allow-unused-prefixes=false"
> Oh `FileCheck` expands into `FileCheck --allow-unused-prefixes=...`? Why not keep `FileCheck` the way it is, then after everything has been fixed/pinned to `--allow-unused-prefixes=false`, change the default value of `allow-unused-prefixes` to true? Regressions should be fairly rare and easily fixable.
> That's what I've been doing for `opt`'s `enable-new-pm` flag.
I'd prefer avoiding the regressions even if rare. The fix here - once the flag default is flipped - is also very simple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94853/new/

https://reviews.llvm.org/D94853