[PATCH] D94648: [amdgpu] Implement lower function LDS pass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 12:08:42 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerFunctionLDSPass.cpp:215
+    // On ties, sort by size, descending, then by name, lexicographical.
+    llvm::sort(
+        FoundLocalVars.begin(), FoundLocalVars.end(),
----------------
Probably should use stable_sort, if the values are anonymous the final compare won't provide ordering


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94648/new/

https://reviews.llvm.org/D94648



More information about the llvm-commits mailing list