[PATCH] D94882: [MC] Upgrade DWARF version to 5 upon .file 0

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

A few thoughts:

1. If gnu-as already has accepted such a patch, we probably want to do the same just for compatibility
2. it doesn't seem like adding a directive sooner (especially if it risks diverging from gnu-as if they add one in the future - they don't tend to be terribly interested in compatibility with clang from my experience) significantly reduces work here, especially if we're doing (1) - add the directive when it becomes necessary if file 0 becomes invalid in DWARFv6 or something (though I don't expect it to any time soon) or more likely if a new line table format arises with significant benefits/incompatibilities with the v5 line table format
3. I'd be pretty happy with clang -gdwarfN and llvm-mc -dwarf-version doing the same thing & ignoring the specified format if the input contains dwarf of a different version - not too fussed in any direction for llvm-mc though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94882/new/

https://reviews.llvm.org/D94882