[PATCH] D94853: [NFC] Disallow unused prefixes under Other

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Other/lit.local.cfg:6-7
+# the default substitution of FileCheck will replace it to its full path.
+config.substitutions.insert(0, (fc.regex,
+    'FileCheck --allow-unused-prefixes=false'))
+config.substitutions.append(('%FileCheckRaw%', 'FileCheck'))
----------------
pardon my ignorance, but why is this substitution necessary? does opt-bisect-legacy-pass-manager.ll break with `--allow-unused-prefixes=true`?


================
Comment at: llvm/test/Other/new-pass-manager.ll:369
 ; CHECK-EXT-NEXT: Finished llvm::Function pass manager run.
+; We don't have checks for CHECK-NOEXT here, but this simplifies the test, while
+; avoiding FileCheck complaining about the unused prefix.
----------------
mtrofin wrote:
> aeubanks wrote:
> > MaskRay wrote:
> > > mtrofin wrote:
> > > > @aeubanks : this test has CHECK-EXT asserts, but not CHECK-NOEXT. Is there a meaningful CHECK-NOEXT I could add? (other than {{.*}} )
> > > `llvm/test/lit.cfg.py` defines `%llvmcheckext`, which expands to either CHECK-EXT or CHECK-NOEXT. You'll need two builds to verify.
> > There's nothing to check for CHECK-NOEXT
> (combining the 2 comments) so then adding the artificial CHECK-NOEXT check is ok? The alternative is to not use %llvmcheckext here, and just explicitly use the CHECK-EXT prefix.
Yeah I think adding the `CHECK-NOEXT` is fine. We need `%llvmcheckext` to test both configurations when the extension is enabled and when it isn't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94853/new/

https://reviews.llvm.org/D94853