[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:443
   let allowedClauses = [
-    VersionedClause<OMPC_TaskReduction>,
-    VersionedClause<OMPC_Allocate>
+    VersionedClause<OMPC_TaskReduction, 50>,
+    VersionedClause<OMPC_Allocate, 50>
----------------
kiranchandramohan wrote:
> sameeranjoshi wrote:
> > kiranchandramohan wrote:
> > > Are tests failing due to task_reduction/allocate marked as version 5.0?
> > All clang related OpenMP tests are failing which contain flag `-fopenmp-version=45` for compilation along with `-fopenmp`.
> > The difference of 4.5 and 5.0 specifically mentions these clauses to in 5.0 standard which was the reason to add `50`.
> > Should we remove this string do is there some other place to change in TableGen?
> I think in general for these situation we have chosen not to add the 5.0 version. Is that right @clementval?
> 
> But correcting these testcases is probably the right thing to do. But for that we might need some inputs from @jdoerfert  or @Meinersbur.
Flang is not using this information now but clang is using it. So if you introduce the version on those clauses and some clang/openmp tests are failing they should be investigated. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93373/new/

https://reviews.llvm.org/D93373