[PATCH] D94984: [NFC][AIX] not functionality changing of function TargetMachine::shouldAssumeDSOLocal()

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 10:41:22 PST 2021


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/TargetMachine.cpp:153
+  assert(TT.isOSBinFormatELF() || TT.isOSBinFormatWasm() || TT.isOSBinFormatXCOFF());
   assert(RM != Reloc::DynamicNoPIC);
   return false;
----------------
I think this looks right, but I'm not sure an extra assert is entirely "NFC".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94984/new/

https://reviews.llvm.org/D94984



More information about the llvm-commits mailing list