[PATCH] D94972: [SLP]Need to shrink the load vector after reordering.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 10:32:47 PST 2021


ABataev added a comment.

In D94972#2507344 <https://reviews.llvm.org/D94972#2507344>, @echristo wrote:

> I think this would be more clear as a combined patch rather than 3 separate and some reverted patches. Would it make more sense to revert the chain and put them all back together in a single review?

There is no chain, actually. And the patch, that caused the problem, is not directly related.
D92668 <https://reviews.llvm.org/D92668> just improves the cost model by squashing multiple shuffles. This one fixes the issue in the code that existed even before D92668 <https://reviews.llvm.org/D92668> and D92668 <https://reviews.llvm.org/D92668> just revealed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94972/new/

https://reviews.llvm.org/D94972



More information about the llvm-commits mailing list