[PATCH] D93912: [libc++][P1679] add string contains
Zoe Carver via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 19 09:13:41 PST 2021
zoecarver added a comment.
> It's unclear to me if I should add noexcept to the const char* overloads.
I think @mclow.lists is right. We shouldn't have noexcept here, and we also need to remove it from some of the `__str_find` overloads (as a separate patch, which I'm happy to make).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93912/new/
https://reviews.llvm.org/D93912
More information about the llvm-commits
mailing list