[PATCH] D94938: [lld-macho][NFC] Add new option group for versions

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 08:55:45 PST 2021


compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

This adds additional options while also adding a group for the versions.  Is there a reason for the group to be added?  Can you please either remove the newly added options or adjust the commit message?  I think that there should be some reasoning given for the version group creation (at least, it isn't clear to me why the group is helpful/necessary, unlike in clang where the group can be used to silence warnings).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94938/new/

https://reviews.llvm.org/D94938



More information about the llvm-commits mailing list