[PATCH] D94891: [Coroutine] Remain alignment information when merging frame variables

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 08:50:49 PST 2021


lxfind added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1123
         Builder.CreateInBoundsGEP(FrameTy, FramePtr, Indices));
-    if (isa<AllocaInst>(Orig)) {
+    if (auto *AI = dyn_cast<AllocaInst>(Orig)) {
       // If the type of GEP is not equal to the type of AllocaInst, it implies
----------------
Is this change unintentional? It seems to be AI and Orig is the same thing. What's the reason to use AI below instead of just Orig?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94891/new/

https://reviews.llvm.org/D94891



More information about the llvm-commits mailing list