[PATCH] D94285: [llvm] Protect signpost map with a mutex

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 08:41:56 PST 2021


JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: llvm/lib/Support/Signposts.cpp:42
   DenseMap<const void *, os_signpost_id_t> Signposts;
+  std::mutex Mutex;
 
----------------
dsanders wrote:
> Timer.cpp uses `sys::SmartMutex` so that single threaded builds don't have to do the mutex. We should do the same here unless there's a good reason to use std::mutex
Makes sense, thanks, I've updated the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94285/new/

https://reviews.llvm.org/D94285



More information about the llvm-commits mailing list