[PATCH] D92282: [VPlan] Handle scalarized values in VPTransformState.

Gil Rapaport via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 07:37:22 PST 2021


gilr added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:242
+        Builder.CreateExtractElement(VecPart, Builder.getInt32(Instance.Lane));
+    // set(Def, Extract, Instance);
+    return Extract;
----------------
Why is this commented out?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:274
+
+    typedef SmallVector<SmallVector<Value *, 4>, 2> ScalarsPerPartValuesTy;
+    DenseMap<VPValue *, ScalarsPerPartValuesTy> PerPartScalars;
----------------
Better to use using?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92282/new/

https://reviews.llvm.org/D92282



More information about the llvm-commits mailing list