[PATCH] D94912: [llvm-nm][ELF] - Use @@ prefix when printing default versions.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/dynamic.test:74
 # VERSIONED-SYMS-NEXT: U localversym
-# VERSIONED-SYMS-NEXT: U version2sym at v2
+# VERSIONED-SYMS-NEXT: U version2sym@@v2
 # VERSIONED-SYMS-NEXT: U version3sym at v3hidden
----------------
MaskRay wrote:
> A default version (`@@`) is only available for defined symbols.
> 
> Undefined symbols should use `@` everywhere.
> 
> (I reported a similar bug to GNU readelf --dyn-syms some time last year)
Seems we have an issue with `llvm-readelf` too then (with `ELFFile<ELFT>::getSymbolVersionByIndex`, which returns `IsDefault` actually).
It should be fixed first, I'll take a look a bit later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94912/new/

https://reviews.llvm.org/D94912