[PATCH] D94516: [flang][driver] Add standard predefinitions

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 05:10:22 PST 2021


awarzynski accepted this revision.
awarzynski added a comment.

LGTM @FarisRehman , thank you!



================
Comment at: flang/test/Flang-Driver/compiler-defined-macros.f90:1
+! Check that the driver supports the standard predefinitions that f18 does.
+
----------------
[nit] IMHO we shouldn't be making a reference to `f18` here. This test simply verifies that `flang-new` correctly defines macro pre-definitions for the compiler version. Perhaps the file could be renamed to reflect that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94516/new/

https://reviews.llvm.org/D94516



More information about the llvm-commits mailing list