[PATCH] D94894: [RISCV] Add way to mark CompressPats that should only be used for compressing.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 04:48:31 PST 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoC.td:904
                   (C_JR GPRNoX0:$rs1)>;
+let isCompressOnly = true in {
 def : CompressPat<(ADD GPRNoX0:$rs1, X0, GPRNoX0:$rs2),
----------------
frasercrmck wrote:
> Is there a reason why this is `true` but the others are `1`?
I think I wrote this one first and forced myself to use true. I made sure it worked then came back and did the others. I guess I fell back into not expecting true/false in tablegen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94894/new/

https://reviews.llvm.org/D94894



More information about the llvm-commits mailing list