[PATCH] D94891: [Coroutine] Remain alignment information when merging frame variables

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM with comments inline. While it's a simple fix, I'm not especially familiar with coroutines, so it'd be nice if someone else could chime in before landing.



================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:608-612
+      bool Alignable = [&]() -> bool {
+        auto *LargestAlloca = *AllocaSet.begin();
+        return LargestAlloca->getAlign().value() % Alloca->getAlign().value() ==
+               0;
+      }();
----------------
This doesn't need to be a lambda, it's only called once


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1129
+      //
+      // Note: If we change the strategy dealing with alignment, we need refine
+      // this casting.
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94891/new/

https://reviews.llvm.org/D94891