[PATCH] D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 01:51:53 PST 2021


RKSimon added a comment.

In D88385#2505260 <https://reviews.llvm.org/D88385#2505260>, @jrtc27 wrote:

> In D88385#2505204 <https://reviews.llvm.org/D88385#2505204>, @RKSimon wrote:
>
>> Thanks @myhsu!
>>
>> @jrtc27 - you're still blocking this - is there anything else you think we need to address here?
>
> For this review, no. There are a bunch of outstanding issues on the other reviews though that need addressing; I don't know if it makes sense to land this now or wait and land them all in one go once the other reviews are fixed and approved.

The plan is for the entire patch series to be accepted before any are pushed. Given how close we are to the next release branch (26 Jan iirc) I'd like to suggest that even if they all get accepted before then, we should delay the pushes to shortly after that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88385/new/

https://reviews.llvm.org/D88385



More information about the llvm-commits mailing list